Skip C++ types when generating Destroy witnesses #6732
Merged
jonmeow merged 2 commits intocarbon-language:trunkfrom Feb 14, 2026
Merged
Skip C++ types when generating Destroy witnesses #6732jonmeow merged 2 commits intocarbon-language:trunkfrom
jonmeow merged 2 commits intocarbon-language:trunkfrom
Conversation
Contributor
Author
jonmeow
force-pushed
the
destroy-skip-cpp
branch
from
bca355a to
500f2b5
Compare
chandlerc
reviewed
Feb 13, 2026
Contributor
chandlerc
left a comment
chandlerc
left a comment
There was a problem hiding this comment.
Generally makes sense, but a question about enums inline.
jonmeow
force-pushed
the
destroy-skip-cpp
branch
from
500f2b5 to
b079c8e
Compare
Assisted-by: Google Antigravity with Gemini 3 Flash
jonmeow
force-pushed
the
destroy-skip-cpp
branch
from
c248aae to
c15022e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This TODO had been written before C++ types were generating destroy implementations, which is resolved now.
Assisted-by: Google Antigravity with Gemini 3 Flash