Skip to content

Remove SemIR dump from AssertSameType int tests#6705

Merged
danakj merged 1 commit intocarbon-language:trunkfrom
nicholasbishop:push-tystorowzuvq
Feb 9, 2026
Merged

Remove SemIR dump from AssertSameType int tests#6705
danakj merged 1 commit intocarbon-language:trunkfrom
nicholasbishop:push-tystorowzuvq

Conversation

@nicholasbishop
Copy link
Contributor

@nicholasbishop nicholasbishop commented Feb 6, 2026

Dropping the SemIR dump significantly decreases the size of these test files. This is a good tradeoff since the interesting signal from these tests is provided by AssertSameType not causing an error.

...n/check/testdata/interop/cpp/builtins.llp64.carbon | 3152 ----------------------
...in/check/testdata/interop/cpp/builtins.lp64.carbon | 3328 ------------------------
2 files changed, 0 insertions(+), 6480 deletions(-)

@nicholasbishop
Remove SemIR dump from AssertSameType int tests
60e02d9 
Dropping the SemIR dump significantly decreases the size of these test
files. This is a good tradeoff since the interesting signal from these
tests is provided by `AssertSameType` not causing an error.
@nicholasbishop nicholasbishop requested a review from a team as a code owner February 6, 2026 21:48
@nicholasbishop nicholasbishop requested review from danakj and removed request for a team February 6, 2026 21:48
danakj
danakj approved these changes Feb 9, 2026
View reviewed changes
Copy link
Contributor

@danakj danakj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@danakj danakj enabled auto-merge February 9, 2026 15:20
@danakj danakj added this pull request to the merge queue Feb 9, 2026
Merged via the queue into carbon-language:trunk with commit a465018 Feb 9, 2026
9 checks passed
@nicholasbishop nicholasbishop deleted the push-tystorowzuvq branch February 9, 2026 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@danakj danakj danakj approved these changes

Assignees

No one assigned

Labels

toolchain

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@nicholasbishop @danakj