Lex/parse support for ->?, :?, and form literals#6695
Merged
dwblaikie merged 2 commits intocarbon-language:trunkfrom Feb 7, 2026
Merged
Lex/parse support for ->?, :?, and form literals#6695dwblaikie merged 2 commits intocarbon-language:trunkfrom
dwblaikie merged 2 commits intocarbon-language:trunkfrom
Conversation
See carbon-language#5389 (pending) for the language design.
Contributor
Author
|
OK, this is ready for review now. |
dwblaikie
approved these changes
Feb 7, 2026
Contributor
dwblaikie
left a comment
dwblaikie
left a comment
There was a problem hiding this comment.
Other than some varying-degrees-of-unrelated (some that had to come before this patch, like value -> val renaming, some that seem more drive-by/could've come before or after) changes that'd be great to separate things like that in the future, looks good!
|
|
||
| interface I { | ||
| let val:! array(i32, 1); | ||
| let value:! array(i32, 1); |
Contributor
There was a problem hiding this comment.
Probably would've been nice if this val->value were a separate cleanup patch to reduce the changes in this patch/make it easier to focus on the semantic changes.
| // 2. ExprInPostfixLoop | ||
| // | ||
| // [ | ||
| // array |
Contributor
There was a problem hiding this comment.
It'd be good to keep unrelated changes in separate patches.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #5389 (pending) for the language design.