Repository navigation
Parse runnable shim specs as YAML - #3708
Merged
rsteube merged 2 commits intoOct 25, 2026
Merged
Conversation
The YAML-based runnable check parses every spec in full, which paid noticeable cost on large or numerous specs at shell startup. A SIMD substring guard skips the parse for specs that cannot contain a run key at all, and the per-spec update loop now runs on a bounded worker pool so bulk changes no longer block startup serially. Benchmarks on the man-page spec corpus document the remaining scanline-vs-YAML tradeoff for future changes. Assisted-by: Crush:z-ai/glm-5.3-flash
rsteube
approved these changes
Oct 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2901
Summary
runkey on the document's mapping rootValidation
go test -count=1 -v ./cmd/carapace/cmd/shimgo generate ./cmd/...go install -v -tags force_all ./cmd/carapacestaticcheck ./cmd/carapace/cmd/shimgofmt -d -s cmd/carapace/cmd/shim/shim.go cmd/carapace/cmd/shim/shim_test.gogit diff --checkgo test -count=1 -v ./cmd/...also ran. Its two existing invoke-completion tests fail because the sandbox'scarapaceresolves to./carapace; the same failures were reproduced from an exact-basegit archivecontrol. The shim package and all other reported command packages pass.