add new page to shortcut#3
Merged
captainbrosset merged 1 commit intocaptainbrosset:pwa-shortcutsfrom Jun 5, 2023
Merged
Conversation
captainbrosset
approved these changes
Jun 5, 2023
captainbrosset
pushed a commit
that referenced
this pull request
Dec 8, 2023
* Add `cancel` event https://html.spec.whatwg.org/multipage/indices.html#event-cancel: Fired at dialog elements when they are canceled by the user (e.g., by pressing the Escape key), or at input elements in the File state when the user does not change their selection * 📝 Make linter happy Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * 📝 Add an example * 📝 highlight * 🐛 typo * 📝 Move cancel_event to HTMLElement * 🔥 Removed original HTMLDialogElement/cancel_event * 📝 Update all links * 🐛 Sort redirects * chore: Merge suggestion #1 Co-authored-by: Estelle Weyl <[email protected]> * chore: Merge suggestion #2 Co-authored-by: Estelle Weyl <[email protected]> * chore: Merge suggestion #3 Co-authored-by: Estelle Weyl <[email protected]> * chore: Merge suggestion mdn#4 Co-authored-by: Estelle Weyl <[email protected]> * chore: Merge suggestion (5) Co-authored-by: Estelle Weyl <[email protected]> * chore: Merge suggestion (6) Co-authored-by: Estelle Weyl <[email protected]> * Update files/en-us/web/html/element/input/file/index.md Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Estelle Weyl <[email protected]> Co-authored-by: Estelle Weyl <[email protected]>
captainbrosset
pushed a commit
that referenced
this pull request
Dec 21, 2023
* chore: .js --> .jsx * chore: remove unnecessary react import * chore: clean up todo markup * chore: remove undefined return warning * chore: tweak props rendering instructions * chore: better explain id collision * chore: index.jsx --> main.jsx * chore: use optional chaining consistently * chore: use implicit boolean for completed * nit: a word * chore: remove default react import * chore: remove unused props * chore: edit jsx note * chore: use brace expansion in bash command * chore: add eslint note * chore: fix todo code snippet * chore: edit final import instructions * Small text tweaks * chore: apply suggestions from code review Co-authored-by: Chris Mills <[email protected]> * chore: apply suggestions from code review Co-authored-by: Chris Mills <[email protected]> * chore: update "make a todo" instructions * clean up "id please" section * chore: clean up "tasks as data" * chore: small cleanup * Small grammar fix * Small tweak --------- Co-authored-by: Chris Mills <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
not sure if this way of doing PRs works.