Repository navigation
Commit 4b7bc8b
authored
fix: reject correlated IN/NOT IN over a groupless aggregate (apache#26677)
## Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and
enhancements and this helps us generate change logs for our releases.
You can link an issue to this PR using the GitHub syntax. For example
`Closes apache#123` indicates that this PR will close issue apache#123.
-->
Part of apache#24960. This PR adds a safe rejection until `IN`/`NOT IN`
count-bug compensation is implemented.
## Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly
in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand
your changes and offer better suggestions for fixes.
Please explain the problem you are trying to solve in terms of the
user-visible
behavior, rather than the implementation.
For example, "The code in `foo.rs` doesn't handle nulls" is a symptom of
the
implementation. "COUNT(DISTINCT) returns wrong results when the column
contains
nulls" is the user-visible problem.
-->
A correlated `IN`/`NOT IN` over an aggregate without `GROUP BY` returns
wrong rows when an outer row has no match (see
apache#24960 (comment)).
apache#25391 fixed `EXISTS`/`NOT EXISTS`. `IN`/`NOT IN` will be covered in a
follow-up, so until then these queries should error instead of returning
wrong results.
## What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here, but it
is sometimes worth providing a summary of the individual changes in this
PR.
-->
`build_join` in `decorrelate_predicate_subquery.rs` now keeps these
subqueries correlated, so they fail to plan with a not-implemented
error. The exception is an `IN` in a `WHERE` over an aggregate that is
NULL on empty input (e.g. `max`, `sum`), which the current rewrite
already answers correctly.
## What is the testing strategy for this PR?
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
Briefly describe how this PR is tested, and point to the specific tests
you added. For example: 'This new feature is covered by the
`sqllogictest` cases added in `foo.slt`'.
If this PR does not add tests, explain why. For example, if the change
is already covered by existing tests, please mention it.
You should also check the `codecov` bot reply on this PR to confirm the
changed code is exercised.
-->
- The existing IN over max test still passes unchanged.
- The existing NOT IN over count test now expects the error.
- New tests expect the error for IN over count in a filter and in a
projection, NOT IN over max, and IN over max in a projection.
## Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be
updated before approving the PR.
If there are any breaking changes to public APIs, please add the `api
change` label.
-->
These queries now return a not-implemented error instead of wrong
results.1 parent 63c6ea7 commit 4b7bc8b
2 files changed
Lines changed: 64 additions & 5 deletions
File tree
- datafusion
- optimizer/src
- sqllogictest/test_files
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
854 | 854 | | |
855 | 855 | | |
856 | 856 | | |
| 857 | + | |
| 858 | + | |
| 859 | + | |
| 860 | + | |
| 861 | + | |
| 862 | + | |
| 863 | + | |
| 864 | + | |
| 865 | + | |
| 866 | + | |
| 867 | + | |
| 868 | + | |
| 869 | + | |
| 870 | + | |
| 871 | + | |
| 872 | + | |
| 873 | + | |
| 874 | + | |
| 875 | + | |
| 876 | + | |
| 877 | + | |
| 878 | + | |
| 879 | + | |
| 880 | + | |
| 881 | + | |
| 882 | + | |
| 883 | + | |
| 884 | + | |
| 885 | + | |
857 | 886 | | |
858 | 887 | | |
859 | 888 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2124 | 2124 | | |
2125 | 2125 | | |
2126 | 2126 | | |
2127 | | - | |
2128 | | - | |
| 2127 | + | |
| 2128 | + | |
2129 | 2129 | | |
2130 | | - | |
| 2130 | + | |
| 2131 | + | |
2131 | 2132 | | |
2132 | | - | |
| 2133 | + | |
2133 | 2134 | | |
2134 | | - | |
| 2135 | + | |
| 2136 | + | |
| 2137 | + | |
| 2138 | + | |
| 2139 | + | |
| 2140 | + | |
| 2141 | + | |
| 2142 | + | |
| 2143 | + | |
| 2144 | + | |
| 2145 | + | |
| 2146 | + | |
| 2147 | + | |
| 2148 | + | |
| 2149 | + | |
| 2150 | + | |
| 2151 | + | |
| 2152 | + | |
| 2153 | + | |
| 2154 | + | |
| 2155 | + | |
| 2156 | + | |
| 2157 | + | |
| 2158 | + | |
| 2159 | + | |
| 2160 | + | |
| 2161 | + | |
| 2162 | + | |
| 2163 | + | |
| 2164 | + | |
2135 | 2165 | | |
2136 | 2166 | | |
2137 | 2167 | | |
| |||
0 commit comments