fix: put a real message when user tries to access the WalletUI in insecure context#322
Closed
SLoeuillet wants to merge 1 commit into
Closed
Conversation
SLoeuillet
commented
Apr 10, 2025
SLoeuillet
left a comment
SLoeuillet
left a comment
Contributor
Author
There was a problem hiding this comment.
Actually, when one tries to take a look at the wallet UI, it won't work if not using localhost or https as its code is using Web Crypto API from browser that is only available from a secure context.
Tell it explicitly to the user instead of dying with a cryptic error message
SLoeuillet
changed the title
SLoeuillet
changed the title
…ad of https or localhost Signed-off-by: Stephane Loeuillet <[email protected]>
SLoeuillet
force-pushed
the
wallet-cryptic-error-when-using-unsecured-context
branch
from
c4865f2 to
a08309f
Compare
Contributor
|
Thanks for the contribution! We've merged this internally and it will be included in the next release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Stephane Loeuillet [email protected]