Apply suggestions from code review

anakinMango · canoo · web-flow · commit 12876f6f9aa3 · 2026-04-24T01:01:00.000-06:00
Co-authored-by: Emi &lt;74990983+canoo@users.noreply.github.com&gt;
diff --git a/install.sh b/install.sh
@@ -70,7 +70,7 @@ download_binary() {
         # Extract expected hash for this binary and verify
         local expected
         expected=$(grep "^${binary_name} " "$checksum_file" | awk '{print $1}')
-        if [ -z "$expected" ]; then
+        expected=$(grep "^${binary_name} " "$checksum_file" | awk '{print $1}')
             rm -f "$dest" "$checksum_file"
             fail "Checksum entry for $binary_name not found in checksums.txt"
         fi
@@ -81,7 +81,7 @@ download_binary() {
     elif command -v shasum &>/dev/null; then
         local expected
         expected=$(grep "^${binary_name} " "$checksum_file" | awk '{print $1}')
-        if [ -z "$expected" ]; then
+    expected=$(grep "^${binary_name} " "$checksum_file" | awk '{print $1}')
             rm -f "$dest" "$checksum_file"
             fail "Checksum entry for $binary_name not found in checksums.txt"
         fi
@@ -91,7 +91,8 @@ download_binary() {
         }
     else
         warn "Neither sha256sum nor shasum found — skipping checksum verification"
-    fi
+        rm -f "$dest" "$checksum_file"
+        fail "Neither sha256sum nor shasum found — cannot verify binary integrity. Install coreutils and retry."
 
     rm -f "$checksum_file"
     chmod +x "$dest"
