Skip to content

action: fix inputs for workflows#8

Merged
barrettj12 merged 1 commit intocanonical:mainfrom
mr-cal:inputs
May 12, 2023
Merged

action: fix inputs for workflows#8
barrettj12 merged 1 commit intocanonical:mainfrom
mr-cal:inputs

Conversation

@mr-cal
Copy link
Contributor

@mr-cal mr-cal commented May 11, 2023

Overview

The channel keyword is ignored.

Reproducer

Using the following action ignores the channel keyword:

      - name: Setup LXD
        uses: canonical/setup-lxd@ea57509243d3cf39f8ab926e021bb353947b01b5
        with:
          channel: latest/stable

I also reproduced this by forking this repo and letting the default workflow run.

Details

This test passes, but it is a false positive. ubuntu-latest is 22.04 and is preloaded with 5.0/stable. The test uses with: channel: 5.0/stable, so it doesn't verify if the channel keyword was used. I changed the test to use 4.0/stable, which is no longer the default on ubuntu-latest.

The root cause is that inputs is the correct context, not github.events.inputs (which only works on manually-triggered workflows).

@barrettj12
Copy link
Contributor

Yikes, that's embarrassing. Good catch and thanks for fixing.

@barrettj12 barrettj12 merged commit af495f2 into canonical:main May 12, 2023
barrettj12 added a commit to barrettj12/actions that referenced this pull request May 12, 2023
There is a bug in canonical/[email protected] where the `channel` input is ignored. This has been fixed in v0.1.1. See canonical/setup-lxd#8
barrettj12 added a commit to barrettj12/netplan that referenced this pull request May 12, 2023
There is a bug in canonical/[email protected] where the `channel` input is ignored. This has been fixed in v0.1.1. See canonical/setup-lxd#8
barrettj12 added a commit to barrettj12/netplan that referenced this pull request May 12, 2023
There is a bug in canonical/[email protected] where the `channel` input is ignored. This has been fixed in v0.1.1. See canonical/setup-lxd#8
barrettj12 added a commit to barrettj12/grafana-agent that referenced this pull request May 12, 2023
There is a bug in canonical/[email protected] where the `channel` input is ignored. This has been fixed in v0.1.1. See canonical/setup-lxd#8
barrettj12 added a commit to barrettj12/cleantest that referenced this pull request May 12, 2023
There is a bug in canonical/[email protected] where the `channel` input is ignored. This has been fixed in v0.1.1. See canonical/setup-lxd#8
barrettj12 added a commit to barrettj12/observability that referenced this pull request May 12, 2023
There is a bug in canonical/[email protected] where the `channel` input is ignored. This has been fixed in v0.1.1. See canonical/setup-lxd#8
barrettj12 added a commit to barrettj12/lego-rock that referenced this pull request May 12, 2023
There is a bug in canonical/[email protected] where the `channel` input is ignored. This has been fixed in v0.1.1. See canonical/setup-lxd#8
barrettj12 added a commit to barrettj12/operator-libs-linux that referenced this pull request May 12, 2023
There is a bug in canonical/[email protected] where the `channel` input is ignored. This has been fixed in v0.1.1. See canonical/setup-lxd#8
sed-i pushed a commit to canonical/observability that referenced this pull request May 12, 2023
There is a bug in canonical/[email protected] where the `channel` input is ignored. This has been fixed in v0.1.1. See canonical/setup-lxd#8
benhoyt added a commit to canonical/operator-libs-linux that referenced this pull request May 12, 2023
* update canonical/setup-lxd to v0.1.1

There is a bug in canonical/[email protected] where the `channel` input is ignored. This has been fixed in v0.1.1. See canonical/setup-lxd#8

* Try using 5.0/stable as 5.9/stable doesn't exist

---------

Co-authored-by: Ben Hoyt <[email protected]>
@mr-cal mr-cal deleted the inputs branch May 13, 2023 00:47
slyon pushed a commit to canonical/netplan that referenced this pull request May 15, 2023
* CI: update canonical/setup-lxd to v0.1.1

There is a bug in canonical/[email protected] where the `channel` input is ignored. This has been fixed in v0.1.1. See canonical/setup-lxd#8

* CI: update canonical/setup-lxd to v0.1.1

There is a bug in canonical/[email protected] where the `channel` input is ignored. This has been fixed in v0.1.1. See canonical/setup-lxd#8
daniloegea pushed a commit to canonical/netplan that referenced this pull request May 17, 2023
* CI: update canonical/setup-lxd to v0.1.1

There is a bug in canonical/[email protected] where the `channel` input is ignored. This has been fixed in v0.1.1. See canonical/setup-lxd#8

* CI: update canonical/setup-lxd to v0.1.1

There is a bug in canonical/[email protected] where the `channel` input is ignored. This has been fixed in v0.1.1. See canonical/setup-lxd#8
Saviq pushed a commit to canonical/actions that referenced this pull request Sep 11, 2023
There is a bug in canonical/[email protected] where the `channel` input is ignored. This has been fixed in v0.1.1. See canonical/setup-lxd#8
Oleksii1001 pushed a commit to Oleksii1001/Cleantest that referenced this pull request Oct 23, 2025
There is a bug in canonical/[email protected] where the `channel` input is ignored. This has been fixed in v0.1.1. See canonical/setup-lxd#8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants