Remove requests_unixsocket
#604
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hamistao
force-pushed
the
remove_requests_unixsocket
branch
2 times, most recently
from
302476f to
14f5207
Compare
hamistao
force-pushed
the
remove_requests_unixsocket
branch
from
14f5207 to
9f0a2c5
Compare
added 4 commits
October 1, 2024 08:37
Implementation inspired by `request_unixsocket` own implementation: https://github.com/msabramo/requests-unixsocket/blob/master/requests_unixsocket/adapters.py Method `get_connection_with_tls_context` introduced for compatibility with later `requests` versions, but keeping old `get_connections` to retain compatibility with previously used versions. Keeping this does not imply in a security vulnerability as TLS authentication is not required for Unix Socket connections. Signed-off-by: hamistao <[email protected]>
Signed-off-by: hamistao <[email protected]>
Signed-off-by: hamistao <[email protected]>
Signed-off-by: hamistao <[email protected]>
hamistao
force-pushed
the
remove_requests_unixsocket
branch
from
9f0a2c5 to
fcae421
Compare
Contributor
Author
|
@simondeziel This is ready for a review! |
simondeziel
approved these changes
Oct 1, 2024
Member
simondeziel
left a comment
simondeziel
left a comment
There was a problem hiding this comment.
Excellent, thank you Pedro!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes implementation to connect to a Unix socket without
requests_unixsocket. This allows us to remove this dependency along with the version restrictions forurllib3andrequests;Fixes #583 #600