Use io.StringIO() instead of tempfile.TemporaryFile()#568
Merged
slyon merged 1 commit intocanonical:mainfrom Jan 27, 2026
Merged
Use io.StringIO() instead of tempfile.TemporaryFile()#568slyon merged 1 commit intocanonical:mainfrom
slyon merged 1 commit intocanonical:mainfrom
Conversation
Cellebyte
force-pushed
the
fix/tempfile
branch
from
57ee003 to
91d3ad6
Compare
Signed-off-by: Marcel Fest <[email protected]>
Cellebyte
force-pushed
the
fix/tempfile
branch
from
91d3ad6 to
b571e0c
Compare
Cellebyte
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
We found another one which causes issues in early boot stage of the linux kernel.
As the tempdirs are not mounted in that stage and the SRIOV configuration happens very early on.
Everything around tempfile or tempdir is problematic and fails with an exception.
To fix this I started using
io.StringIOfor everything which needed a temporary buffer.Similar to #564 .
Checklist
make checksuccessfully.make check-coverage).