cli: Fix generate.py to properly handle --root-dir (LP: #2137640)#566
Merged
slyon merged 2 commits intocanonical:mainfrom Jan 12, 2026
Merged
cli: Fix generate.py to properly handle --root-dir (LP: #2137640)#566slyon merged 2 commits intocanonical:mainfrom
slyon merged 2 commits intocanonical:mainfrom
Conversation
slyon
changed the title
slyon
force-pushed
the
lp2137640-generate-root-dir
branch
from
5dd2e60 to
8776cf7
Compare
j5awry
approved these changes
Jan 12, 2026
j5awry
left a comment
j5awry
left a comment
There was a problem hiding this comment.
Thanks for pushing up this fix. One thing that still confuses me is the use case for systemd's installed generator being a different path with root-dir. It differs from how the systemd generator provided by netplan interprets --root-dir.
a better explanation in documentation (be it the CLI or provided docs) and in the changelog would be helpful.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Checklist
make checksuccessfully.make check-coverage).