Only create a tempdir when needed#564
Merged
slyon merged 1 commit intocanonical:mainfrom Dec 16, 2025
Merged
Conversation
902c3c7 to
b42f3ff
Compare
b42f3ff to
1f4c0c3
Compare
slyon
approved these changes
Dec 16, 2025
Contributor
slyon
left a comment
There was a problem hiding this comment.
Thanks for your contribution, LGTM!
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
During early boot the configmanager needs to be initialized before
/tmpis mounted.This causes the
__init__of configmanager to fail.I moved tempdir into a property and only create a directory when restore or backup is called.
Checklist
make checksuccessfully.make check-coverage).