Use OVS from apt before snap when both exist. (LP: #2127195)#563
Merged
slyon merged 1 commit intocanonical:mainfrom Nov 20, 2025
Merged
Use OVS from apt before snap when both exist. (LP: #2127195)#563slyon merged 1 commit intocanonical:mainfrom
slyon merged 1 commit intocanonical:mainfrom
Conversation
slyon
changed the title
Contributor
|
@crypticC0der Thanks for this follow-up on LP#2127195, can you please try to get the CI to green or explain the failures? |
Previously when a user had OVS from both apt and snap, we would use the snap ovs-vsctl, this caused a change in functionality for users with this workflow. This changes this to check /usr/bin first. Signed-off-by: MJ Ponsonby <[email protected]>
Contributor
Author
Sorry Ive been quite busy, the coverage tests still fail but that is unrelated to this patch and is just the state of main at the moment, this patch doesn't change coverage in any way and it didn't feel relevant to add testing to unrelated code in this PR. |
slyon
approved these changes
Nov 20, 2025
Contributor
slyon
left a comment
slyon
left a comment
There was a problem hiding this comment.
Thanks for cleaning this up! The "RPM build (rawhide)" CI failure is indeed unrelated and caused by changes in the Fedora rawhide environment.
LGTM!
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously when a user had OVS from both apt and snap, we would use the snap ovs-vsctl, this caused a change in functionality for users with this workflow. This changes this to check /usr/bin first.
LP#2127195