Ensure netplan directory creation is idempotent#562
Merged
slyon merged 1 commit intocanonical:mainfrom Nov 12, 2025
Merged
Conversation
Added exist_ok=True to os.makedirs() in TestSet.setUp() to prevent errors if the directory already exists. Improves test reliability and idempotence.
slyon
approved these changes
Nov 12, 2025
Contributor
slyon
left a comment
slyon
left a comment
There was a problem hiding this comment.
Thanks for your contribution to Netplan. LGTM!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added exist_ok=True to os.makedirs() in TestSet.setUp() to prevent errors if the directory already exists. Improves test reliability and idempotence.
Description
This change ensures that directory creation in
TestSet.setUp()is idempotent by addingexist_ok=Truetoos.makedirs().Previously, the test could fail if the
etc/netplandirectory already existed.This update improves test robustness and repeatability.
Checklist
make checksuccessfully.make check-coverage).