Skip to content

Fix function prototypes for *_new() functions of parser and state#547

Merged
slyon merged 2 commits intocanonical:mainfrom
JanSoundhouse:function-prototypes
Mar 27, 2025
Merged

Fix function prototypes for *_new() functions of parser and state#547
slyon merged 2 commits intocanonical:mainfrom
JanSoundhouse:function-prototypes

Conversation

@JanSoundhouse
Copy link
Contributor

The state.h and parse.h files are part of the public api of libnetplan. These function prototypes declared there should adhere the c-standard.
Function prototypes for functions that don't take any parameters should have void as the parameter list. Function prototypes with an empty parameter list are treated by the compiler as accepting any arbitrary parameter.

@slyon slyon added the community This PR has been proposed by somebody outside of the Netplan team and roadmap commitments. label Mar 19, 2025
Copy link
Contributor

@slyon slyon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@slyon slyon closed this Mar 27, 2025
@slyon slyon reopened this Mar 27, 2025
@slyon
Copy link
Contributor

slyon commented Mar 27, 2025

closed & re-open to re-trigger the CI.

@slyon slyon merged commit d6e8234 into canonical:main Mar 27, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

community This PR has been proposed by somebody outside of the Netplan team and roadmap commitments.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants