Skip to content

tests:wifi: Replace deprecated ISC dhclient & fail properly#541

Merged
slyon merged 5 commits intocanonical:mainfrom
slyon:dep8-wifis
Feb 6, 2025
Merged

tests:wifi: Replace deprecated ISC dhclient & fail properly#541
slyon merged 5 commits intocanonical:mainfrom
slyon:dep8-wifis

Conversation

@slyon
Copy link
Contributor

@slyon slyon commented Feb 5, 2025 •
edited
Loading

Description

2315s ======================================================================
2315s ERROR: test_wifi_ap_open (__main__.TestNetworkManager.test_wifi_ap_open)
2315s ----------------------------------------------------------------------
2315s Traceback (most recent call last):
2315s   File "/tmp/autopkgtest.M08ut1/build.PMg/src/tests/integration/wifi.py", line 175, in test_wifi_ap_open
2315s     out = subprocess.check_output(['dhclient', '-1', '-v', self.dev_w_ap],
2315s           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
2315s   File "/usr/lib/python3.12/subprocess.py", line 466, in check_output
2315s     return run(*popenargs, stdout=PIPE, timeout=timeout, check=True,
2315s            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
2315s   File "/usr/lib/python3.12/subprocess.py", line 548, in run
2315s     with Popen(*popenargs, **kwargs) as process:
2315s          ^^^^^^^^^^^^^^^^^^^^^^^^^^^
2315s   File "/usr/lib/python3.12/subprocess.py", line 1026, in __init__
2315s     self._execute_child(args, executable, preexec_fn, close_fds,
2315s   File "/usr/lib/python3.12/subprocess.py", line 1955, in _execute_child
2315s     raise child_exception_type(errno_num, err_msg, err_filename)
2315s FileNotFoundError: [Errno 2] No such file or directory: 'dhclient'

2278s setUpClass (__main__.TestNetworkManager) ... skipped "cfg80211 (wireless) is unavailable, can't test"
2278s modprobe: FATAL: Module cfg80211 not found in directory /lib/modules/6.11.0-8-generic
2278s setUpClass (__main__.TestNetworkd) ... skipped "cfg80211 (wireless) is unavailable, can't test"
2278s 
2278s ----------------------------------------------------------------------
2278s Ran 0 tests in 0.895s
2278s 
2278s OK (skipped=2)
2278s modprobe: FATAL: Module cfg80211 not found in directory /lib/modules/6.11.0-8-generic
2279s autopkgtest [01:33:19]: test wifi: -----------------------]
2279s autopkgtest [01:33:19]: test wifi:  - - - - - - - - - - results - - - - - - - - - -
2279s wifi                 PASS

This should go hand-in-hand with (and CI will only PASS again, once that's in Debian testing / Ubuntu devel):

Checklist

  • Runs make check successfully.
  • Retains code coverage (make check-coverage).
  • New/changed keys in YAML format are documented.
  • (Optional) Adds example YAML for new feature.
  • (Optional) Closes an open bug in Launchpad.

@slyon
Copy link
Contributor Author

slyon commented Feb 6, 2025

Now that the netplan 1.1.2-2 packaging landed in Debian and Ubuntu (as used in the CI), CI is green again and we can get this merged.

We can also see that the wifi tests are now properly marked as SKIP:

autopkgtest [09:59:12]: @@@@@@@@@@@@@@@@@@@@ summary
ovs                  PASS
ethernets            PASS
bridges              PASS
bonds                PASS
routing              PASS
vlans                PASS
wifi                 SKIP exit status 77 and marked as skippable
tunnels              PASS
scenarios            PASS
regressions          PASS
dbus                 PASS
dummies              PASS
veths                PASS
diff                 PASS
autostart            PASS
cloud-init           PASS

slyon added 2 commits February 6, 2025 11:03
@slyon
CI: allow wifi test to be skipped
8c8fdff
@slyon
tests:integration: Fix warning about 01-main.yaml permissions
78be0a0 
Avoid warnings like this across the test suite:

** (process:7269): WARNING **: 09:18:54.621: Permissions for /etc/netplan/01-main.yaml are too open. Netplan configuration should NOT be accessible by others.
@slyon slyon merged commit 52ea6f3 into canonical:main Feb 6, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@slyon