Utilize sd-nd-wait-online for waiting on DNS servers#535
Utilize sd-nd-wait-online for waiting on DNS servers#535slyon merged 4 commits intocanonical:mainfrom
Conversation
bd30602 to
53c7bb2
Compare
|
@enr0n and @daniloegea would you mind taking a look at this PR? I'll still keep it as a draft (please don't merge yet), as we need wider availability of the upstream systemd changes, especially in our test runners (i.e. systemd v258+ or backports). But besides that, the PR should be ready for review and comply with the spec linked above. Danilo, do you have any clue what's wrong with the CodeQL (cpp) workflow? Just upgrading from v2 to v3 doesn't seem to do the trick. |
As implemented in systemd (v258): systemd/systemd#34640
1f35511 to
b399d24
Compare
b399d24 to
5e8a3da
Compare
|
The systemd part of this work was landed upstream and backported to https://launchpad.net/ubuntu/+source/systemd/257.2-3ubuntu1, thanks to @enr0n ! I've now finished implementation of the Netplan side and tested it in Ubuntu Plucky (by uncommenting the line after Before merging it, we need to make sure the CI is ready (i.e. systemd v258+ or backport of the feature) and we should also run the full autopkgtest, as described above. @enr0n WDYT? |
|
This is now included in Ubuntu Plucky: https://launchpad.net/ubuntu/+source/netplan.io/1.1.2-1ubuntu1 |
|
This was deployed to Ubuntu Plucky in early February and didn't show any issues. Let's keep the integration test disabled, as the upstream Netplan CI does not yet provide the required systemd v258, but get it merged. |
Description
networkd: wait-online wait for DNS servers to be assigned
As implemented in systemd (v258):
systemd/systemd#34640
Spec: https://discourse.ubuntu.com/t/spec-definition-of-an-online-system/27838
Follow-up to: #482 #456
Checklist
make checksuccessfully.make check-coverage).