networkmanager: add support for stable-ssid MAC option (LP: #2084234)#524
Merged
daniloegea merged 1 commit intocanonical:mainfrom Oct 14, 2024
Merged
networkmanager: add support for stable-ssid MAC option (LP: #2084234)#524daniloegea merged 1 commit intocanonical:mainfrom
daniloegea merged 1 commit intocanonical:mainfrom
Conversation
daniloegea
force-pushed
the
mac_stable_ssid
branch
from
b7be466 to
ff516b8
Compare
daniloegea
commented
Oct 11, 2024
slyon
approved these changes
Oct 14, 2024
Contributor
slyon
left a comment
slyon
left a comment
There was a problem hiding this comment.
Thanks, LGTM! And should be fine to be pulled into the pending 1.1.1 stable release.
I left a small remark about the autopkgtest (thanks for providing one!)
daniloegea
force-pushed
the
mac_stable_ssid
branch
from
ff516b8 to
efb06e1
Compare
802-11-wireless.cloned-mac-address = stable-ssid was added in Network Manager 1.46 and is available through the GUI applet. tests: add integration test for stable-ssid In order to create a predictable MAC address we need to set a fixed /etc/machine-id and /var/lib/NetworkManager/secret_key. Note that this test is currently unstable and skipped by default.
daniloegea
force-pushed
the
mac_stable_ssid
branch
from
efb06e1 to
c53dfcd
Compare
Contributor
|
@daniloegea Regarding the MAC address flakyness, apparently networkd changes to a random MAC address after taking over an interface, changing the original MAC that was assigned when the (test-)interface was created, e.g. via We tried to tackle that in the past, but maybe we're seeing another instance of this here?? 1413f0e |
Contributor
Author
|
It could be something related to that. I think the previous MAC address is used as one of the inputs for the calculation of the new one... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
802-11-wireless.cloned-mac-address = stable-ssid was added in Network Manager 1.46 and is available through the GUI applet.
Fixes https://bugs.launchpad.net/ubuntu/+source/netplan.io/+bug/2084234
Description
Checklist
make checksuccessfully.make check-coverage).