Use more permissive umask for .service units (LP: #2072486)#516
Merged
slyon merged 3 commits intocanonical:mainfrom Sep 12, 2024
Merged
Use more permissive umask for .service units (LP: #2072486)#516slyon merged 3 commits intocanonical:mainfrom
slyon merged 3 commits intocanonical:mainfrom
Conversation
…#2072487) Writing world-inaccessible config files doesn't help when the data can still be accessed by any local user through the systemd APIs, e.g.: "systemctl show UNIT_NAME.service" Using 640 permission on such .service unit files provides a false illusion of security and leads to systemd warnings in the journal, like this: "systemd[1]: Configuration file /run/systemd/system/netplan-ovs-cleanup.service is marked world-inaccessible. This has no effect as configuration data is accessible via APIs without restrictions. Proceeding anyway."
slyon
changed the title
slyon
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
networkd:openvswitch:sriov: Permissive umask for .service units (LP#2072486)
Writing world-inaccessible config files doesn't help when the data can still be accessed by any local user through the systemd APIs, e.g.:
systemctl show UNIT_NAME.serviceUsing
640permission on such .service unit files provides a false illusion of security and leads to systemd warnings in the journal, like this:systemd[1]: Configuration file /run/systemd/system/netplan-ovs-cleanup.service is marked world-inaccessible. This has no effect as configuration data is accessible via APIs without restrictions. Proceeding anyway.Also:
FR-8238
Checklist
make checksuccessfully.make check-coverage).