Skip to content

Several code cleanup & fixes for TiCS#507

Merged
daniloegea merged 2 commits intocanonical:mainfrom
slyon:fix-tics
Aug 23, 2024
Merged

Several code cleanup & fixes for TiCS#507
daniloegea merged 2 commits intocanonical:mainfrom
slyon:fix-tics

Conversation

@slyon
Copy link
Contributor

@slyon slyon commented Aug 19, 2024

Description

Fix some warnings reported by TiCS

  • (6.8.4.b) Expression 'rootdir' is not a proper 'Boolean' condition.
  • (6.10.8.b) Reserved identifier __FUNCTION__ may not be used.
  • (6.3.2.3.d) Encountered conversion between boolean type '(0, 1)' and non-boolean type 'char *'.

Checklist

  • Runs make check successfully.
  • Retains 100% code coverage (make check-coverage).
  • New/changed keys in YAML format are documented.
  • (Optional) Adds example YAML for new feature.
  • (Optional) Closes an open bug in Launchpad.

@slyon slyon marked this pull request as ready for review August 21, 2024 13:48
@slyon slyon marked this pull request as draft August 21, 2024 14:07
@slyon slyon marked this pull request as ready for review August 21, 2024 15:00
@slyon slyon requested a review from daniloegea August 21, 2024 15:46
Copy link
Contributor

@daniloegea daniloegea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@daniloegea daniloegea merged commit a21ed4f into canonical:main Aug 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants