Change default umask when creating dirctories (LP: #2076319)#497
Merged
slyon merged 1 commit intocanonical:mainfrom Aug 13, 2024
Merged
Change default umask when creating dirctories (LP: #2076319)#497slyon merged 1 commit intocanonical:mainfrom
slyon merged 1 commit intocanonical:mainfrom
Conversation
Contributor
|
Thank you for reporting the problem and for the fix. I was inclined to set the group of May I ask you to improve the commit log a little and describe why this change is important? |
Security best practices recommend changing the default umask from 022 to 027 to harden systems. However, when users set umask to 027, netplan creates directories with permissions that are not accessible to backends like systemd-network, resulting in issues during network configuration. This patch ensures that netplan generates directories with a 0755 mask, regardless of the user's umask. fixes: lp2076319
rmalz-c
force-pushed
the
usr/rmalz/fix-lp2076319
branch
from
2026a33 to
bbee680
Compare
Contributor
Author
|
Added proper description in commit msg |
slyon
added
community
slyon
changed the title
slyon
approved these changes
Aug 13, 2024
Contributor
slyon
left a comment
slyon
left a comment
There was a problem hiding this comment.
Thank you very much for your contribution to Netplan!
The change LGTM and indeed resembles what we used to do in previous versions of Netplan. I agree with Danilo that (for now) it is safer to change umask instead of querying users/groups from inside the generator.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
fixes: lp2076319
Checklist
make checksuccessfully.make check-coverage).