Skip to content

Add netplan try to netplan tutorial#494

Merged
slyon merged 2 commits intocanonical:mainfrom
davidekete:Add-netplan-try-to-Netplan-tutorial
Aug 12, 2024
Merged

Add netplan try to netplan tutorial#494
slyon merged 2 commits intocanonical:mainfrom
davidekete:Add-netplan-try-to-Netplan-tutorial

Conversation

@davidekete
Copy link
Contributor

Description

Checklist

  • Runs make check successfully.
  • Retains 100% code coverage (make check-coverage).
  • New/changed keys in YAML format are documented.
  • (Optional) Adds example YAML for new feature.
  • (Optional) Closes an open bug in Launchpad.

Copy link
Contributor

@rkratky rkratky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@slyon Could you please have a look at this (and merge if OK from your side)?

@rkratky rkratky requested a review from slyon August 2, 2024 12:56
@slyon slyon added community This PR has been proposed by somebody outside of the Netplan team and roadmap commitments. documentation Documentation improvements. labels Aug 12, 2024
Copy link
Contributor

@slyon slyon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for your contribution to the Netplan project @davidekete!

LGTM, I will merge it shortly. Sorry for the late reply (I was travelling).

@slyon slyon merged commit a955b0d into canonical:main Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

community This PR has been proposed by somebody outside of the Netplan team and roadmap commitments. documentation Documentation improvements.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants