meson: Add 'testing' option#493
Merged
daniloegea merged 2 commits intocanonical:mainfrom Jul 30, 2024
Merged
Conversation
slyon
force-pushed
the
deb1071599-nocheck-fr8335
branch
from
8fe9474 to
5496a5e
Compare
slyon
force-pushed
the
deb1071599-nocheck-fr8335
branch
from
5496a5e to
d64b597
Compare
daniloegea
suggested changes
Jul 29, 2024
Contributor
daniloegea
left a comment
daniloegea
left a comment
There was a problem hiding this comment.
Thanks, it looks good.
I just have two suggestions:
- In src/meson.build, the block
libnetplan_testingshould also be enabled only whentestingis enabled as it's only used by the ctests. This should probably be addressed before merging. - In the netplan.io package,
libcmocka-devshould probably also be set with<!nocheck>now.
slyon
force-pushed
the
deb1071599-nocheck-fr8335
branch
from
d64b597 to
c824c3e
Compare
Contributor
Author
|
Thanks, I addressed all of your remarks. PTAL. |
slyon
force-pushed
the
deb1071599-nocheck-fr8335
branch
from
c824c3e to
7f577fa
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
See https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1071599
FR-8335
Checklist
make checksuccessfully.make check-coverage).