generate: avoid calling 'udevadm control --reload' (LP: #1999178)#488
generate: avoid calling 'udevadm control --reload' (LP: #1999178)#488daniloegea merged 2 commits intocanonical:mainfrom
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
|
Thinking about it. I feel like it should be fine just dropping the At runtime, we can do whatever we need, through the Python CLI. I'm pondering about adopting the |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
The udev rules directories are monitored and re-loaded automatically with modern systemd-udevd. No need to manually reload them in the generator, causing side-effects. We can still force-reload them when issuing 'netplan generate' or 'netplan apply' through the CLI, just to be on the safe side. Replaces: canonical#304
|
We've used this in the Ubuntu devel series for a while now and didn't observe any fallout. @daniloegea WDYT? |
|
It seems to be working fine. The only thing I've found so far, that might not be related to this change, is that the integration test |
daniloegea
left a comment
There was a problem hiding this comment.
The test I've been investigating seems to be flaky on ppc64el. After running it a bunch of times it passed once. But it's passing on Oracular where this patch is already present. It seems it's not related to it, I'll go ahead and merge this PR.
Description
The udev rules directories are monitored and re-loaded automatically with modern systemd-udevd. No need to manually reload them in the generator, causing side-effects.
We can still force-reload them when issuing
netplan generateornetplan applythrough the CLI, just to be on the safe side.Replaces: #304
Checklist
make checksuccessfully.make check-coverage).