Merged
Conversation
There was a single bullet point that divided a sentence. I removed it because I thought it was a typo.
slyon
added
community
slyon
suggested changes
Jun 26, 2024
Contributor
slyon
left a comment
slyon
left a comment
There was a problem hiding this comment.
Oh good catch!
I guess it was never meant to be a bullet point, but rather an emphasis on the "completely replace" words, removing just one of the dashes would break up that structure, so maybe we should completely change it, e.g. by putting the "(completely replace)" into parentheses?
WDYT? And thank you very much for your contribution to Netplan!
Co-authored-by: Lukas Märdian <[email protected]>
slyon
approved these changes
Jun 27, 2024
Contributor
slyon
left a comment
slyon
left a comment
There was a problem hiding this comment.
Thanks for addressing my remarks. LGTM!
daniloegea
pushed a commit
that referenced
this pull request
Jul 3, 2024
* bullet point removal There was a single bullet point that divided a sentence. I removed it because I thought it was a typo.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was a single bullet point that divided a sentence. I removed it because I thought it was a typo.
Description
Checklist
make checksuccessfully.make check-coverage).