Skip to content

Create single-nic-vm-host.md#475

Merged
slyon merged 6 commits intocanonical:mainfrom
ilvipero:patch-1
Jun 19, 2024
Merged

Create single-nic-vm-host.md#475
slyon merged 6 commits intocanonical:mainfrom
ilvipero:patch-1

Conversation

@ilvipero
Copy link
Contributor

Description

This how to covers the scenario of a single NIC virtual machine host based on Ubuntu, and walks users through the required configuration steps using netplan and virsh.

Checklist

  • Runs make check successfully.
  • Retains 100% code coverage (make check-coverage).
  • New/changed keys in YAML format are documented.
  • (Optional) Adds example YAML for new feature.
  • (Optional) Closes an open bug in Launchpad.

This how to covers the scenario of a single NIC virtual machine host based on Ubuntu, and walks users through the required configuration steps using netplan and virsh.
@slyon slyon requested a review from rkratky May 29, 2024 09:29
@slyon slyon added community This PR has been proposed by somebody outside of the Netplan team and roadmap commitments. documentation Documentation improvements. labels May 29, 2024
Copy link
Contributor

@slyon slyon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution to Netplan!

Some initial comments from my side, but let's wait for Robert's feedback as well.

Copy link
Contributor

@rkratky rkratky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have more formatting suggestions, and doing it through GH comments would be a bit cumbersome, so I'm going to submit a PR against Mauro's branch.

@slyon slyon added the Canonical by Canonical employees outside the Netplan team label Jun 5, 2024
@slyon
Copy link
Contributor

slyon commented Jun 19, 2024

FTR: some fixes landed via ilvipero#1

Copy link
Contributor

@slyon slyon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, lgtm with the latest fixes!

@slyon slyon merged commit e5f4edd into canonical:main Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Canonical by Canonical employees outside the Netplan team community This PR has been proposed by somebody outside of the Netplan team and roadmap commitments. documentation Documentation improvements.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants