Merged
Conversation
This how to covers the scenario of a single NIC virtual machine host based on Ubuntu, and walks users through the required configuration steps using netplan and virsh.
slyon
reviewed
May 29, 2024
Contributor
slyon
left a comment
There was a problem hiding this comment.
Thanks for your contribution to Netplan!
Some initial comments from my side, but let's wait for Robert's feedback as well.
Co-authored-by: Lukas Märdian <[email protected]>
rkratky
requested changes
Jun 5, 2024
Contributor
rkratky
left a comment
There was a problem hiding this comment.
I have more formatting suggestions, and doing it through GH comments would be a bit cumbersome, so I'm going to submit a PR against Mauro's branch.
Co-authored-by: Robert Krátký <[email protected]>
Co-authored-by: Robert Krátký <[email protected]>
Reformat the single-nic-vm-host howto
Contributor
|
FTR: some fixes landed via ilvipero#1 |
slyon
approved these changes
Jun 19, 2024
Contributor
slyon
left a comment
There was a problem hiding this comment.
Thanks, lgtm with the latest fixes!
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This how to covers the scenario of a single NIC virtual machine host based on Ubuntu, and walks users through the required configuration steps using netplan and virsh.
Checklist
make checksuccessfully.make check-coverage).