sriov: don't generate duplicate entries in the rebind.service file#437
Merged
daniloegea merged 3 commits intocanonical:mainfrom Jan 25, 2024
Merged
Conversation
We are not checking if the systemd units generated are correct.
This test is currently failing due to interface duplicates being added to the list.
When multiple VFs are present in the configuration, we end up generating many duplicates in the netplan-sriov-rebind.service file. Use a hash set to store the PFs and automatically deduplicate entries.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The
sriov-rebind.servicewill have duplicates when multiple VFs are being created. See below:Checklist
make checksuccessfully.make check-coverage).