Merged
Conversation
Contributor
|
Please rebase, now that CI is adopted after #434 |
We are parsing all the configuration unnecessarily here. np_state is being overridden by the State instance from the config manager. Fix a related unit test. The configuration is expected to fail but now it's failing in a different place and raising a different exception.
daniloegea
force-pushed
the
cli_sriov_1
branch
from
dcc369b to
8dc1976
Compare
slyon
approved these changes
Jan 25, 2024
Contributor
slyon
left a comment
slyon
left a comment
There was a problem hiding this comment.
LGTM!
This was apparently a left-over from times where configmanager.py was not using netplan.Parser() and netplan.State() logic yet, but had its own Netplan parser, implemented in Python.
See #253 (comment) for reference.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We are parsing all the configuration unnecessarily here. np_state is being overridden by the State instance from the config manager.
Fix a related unit test. The configuration is expected to fail but now it's failing in a different place and raising a different exception.
Description
Checklist
make checksuccessfully.make check-coverage).