ABI: Refactoring for libnetplan.so.1#434
Merged
slyon merged 7 commits intocanonical:mainfrom Jan 22, 2024
Merged
Conversation
slyon
changed the title
slyon
force-pushed
the
pre-1.0
branch
2 times, most recently
from
fd4f857 to
89ebac9
Compare
The new systemd-dev build-dependency is not available on Jammy. But it is part of the 'systemd' B-D itself.
slyon
force-pushed
the
pre-1.0
branch
2 times, most recently
from
79baf2b to
e6b3c7d
Compare
daniloegea
approved these changes
Jan 18, 2024
Contributor
daniloegea
left a comment
daniloegea
left a comment
There was a problem hiding this comment.
lgtm! I just left 2 non-blocking comments.
Contributor
|
Oh, about the Network Manager tests. I'm not sure why they are failing :( I tried it locally with netplan.io from -proposed and systemd from release (253) they just work... not sure if it's related to the usrmerge stuff... |
Contributor
|
wait... we got rid of the old .0 shared library, Network Manager needs to be rebuilt on Noble to work properly. |
Contributor
Author
Ahh, yes! That might be it. On the distro side this will be enforced by changing the |
slyon
force-pushed
the
pre-1.0
branch
5 times, most recently
from
1e8a30b to
13b067c
Compare
Also re-build the NetworkManager package during test, to account for the new libnetplan.so.1 shared object.
They are now all encapsulated inside the netplan_state struct, to be used through the API. Also, restructure the generator's includes for better separation of public vs internal headers.
slyon
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Please review commit-by-commit.
Bumping libnetplan's SOVERSION to 1, indicating breaking changes. Also, bumping Netplan's version to "1.0" already, in preparation for the next release.
I've dropped some more legacy code and cleaned up the existing public & internal APIs, making sure we do not export anything that is either prefixed with
_netplan_(internal API) ornetplan_(public API).Note
Feel free to ignore the last (big) commit in "abi-compat", as that is auto-generated (e6b3c7d)
Known issues
One thing I noticed already is, that it is building against
noble-releaseusing systemd v253 (instead of v255 from -proposed), therefore getting the wrong systemd-generator path frompkgconf.FR-3760
Checklist
make checksuccessfully.make check-coverage).