ctests: stop including C files in the test files#432
Merged
daniloegea merged 1 commit intocanonical:mainfrom Jan 16, 2024
Merged
ctests: stop including C files in the test files#432daniloegea merged 1 commit intocanonical:mainfrom
daniloegea merged 1 commit intocanonical:mainfrom
Conversation
Contributor
|
This approach sounds reasonable to me. Especially with the default CC @fnordahl WDYT? Would that work for you? |
With these changes, a copy of libnetplan without static functions will be build. All the test files will be linked against this separate library. With that, there is no need to include the C files in the test files anymore. To make this possible, all the static keywords in function declarations were replaced with a macro that will be defined at compilation time.
daniloegea
force-pushed
the
ctests_improvements
branch
from
c562105 to
5d30624
Compare
Contributor
Author
|
Rebased on top of the last batch of commits. |
slyon
approved these changes
Jan 16, 2024
Contributor
slyon
left a comment
slyon
left a comment
There was a problem hiding this comment.
This is a nice refactoring that makes testing easier. It doesn't affect the production code.
LGTM, let's get this merged!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With these changes, a copy of libnetplan without static functions will be build. All the test files will be linked against this separate library. With that, there is no need to include the C files in the test files anymore.
To make this possible, all the static keywords in function declarations were replaced with a macro that will be defined at compilation time.
Description
My goal is to make #425 easier to be implemented. Also, refactoring the C code is less likely to break the build of test files...
Checklist
make checksuccessfully.make check-coverage).