ovs: disable StartLimitBurst in the ovs-cleanup service (LP: #2047827)#431
Merged
daniloegea merged 1 commit intocanonical:mainfrom Jan 8, 2024
Merged
Conversation
With systemd 255, the ovs integration test is hitting this limit and the test fails due to that. As it's a oneshot service, it should be OK to disable this limit.
slyon
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With systemd 255, the ovs integration test is hitting this limit and the test fails due to that. As it's a oneshot service, it should be OK to disable this limit.
Description
The alternative solution is to add a delay between each OVS integration test. In my tests, the required delay to get all the tests passing was 3 seconds. This change is to avoid increasing the time spent during tests.
LP bug: https://bugs.launchpad.net/ubuntu/+source/netplan.io/+bug/2047827
What do you think, Lukas?
Checklist
make checksuccessfully.make check-coverage).