parse-nm/wg: append the correct prefix to IPv6 addresses (LP: #2046158)#428
Merged
slyon merged 1 commit intocanonical:mainfrom Jan 4, 2024
Merged
parse-nm/wg: append the correct prefix to IPv6 addresses (LP: #2046158)#428slyon merged 1 commit intocanonical:mainfrom
slyon merged 1 commit intocanonical:mainfrom
Conversation
When the prefix is omitted for IPs in the allowed-ips list, we were appending a /32 to them without checking the address family. IPv6 addresses will have a /128 appended to them if it's not present. See LP: #2046158
Contributor
|
That looks exactly right, thanks @daniloegea ! |
slyon
changed the title
slyon
approved these changes
Jan 4, 2024
Contributor
slyon
left a comment
slyon
left a comment
There was a problem hiding this comment.
Thank you, LGTM. The modified unit-test is covering the case.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the prefix is omitted for IPs in the allowed-ips list, we were appending a /32 to them without checking the address family.
IPv6 addresses will have a /128 appended to them if it's not present.
See LP#2046158
Description
Checklist
make checksuccessfully.make check-coverage).