state_diff: fix filtering of host scoped routes#426
Merged
slyon merged 1 commit intocanonical:mainfrom Jan 25, 2024
Merged
Conversation
When an interface has multiple IPs in the same subnet, there will be host scoped routes for each of them and the "src" address will be one of the IPs for all of them. The filtering of this type of route was not working properly and including the extra routes in the diff. This change generalizes the verification to see if the destination address is one of the system own addresses instead of comparing it with the src address. While here, fix the data structure passed to the filtering method. It should be a list but a dictionary was being passed to it.
Contributor
Author
|
This patch was integrated in this PPA https://launchpad.net/~danilogondolfo/+archive/ubuntu/netplan-diff/ |
slyon
approved these changes
Jan 25, 2024
Contributor
slyon
left a comment
slyon
left a comment
There was a problem hiding this comment.
LGTM, in order to fix the current logic, passing a dict instead of a list.
But beware that in spec FO113 there's some discussion about the filtering of routes. So this logic might change in the future.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When an interface has multiple IPs in the same subnet, there will be host scoped routes for each of them and the "src" address will be one of the IPs for all of them.
The filtering of this type of route was not working properly and including the extra routes in the diff.
This change generalizes the verification to see if the destination address is one of the system own addresses instead of comparing it with the src address.
While here, fix the data structure passed to the filtering method. It should be a list but a dictionary was being passed to it.
Description
Checklist
make checksuccessfully.make check-coverage).