Migrate CriticalConnection (deprecated) to KeepConfiguration (LP: #1896799)#424
Conversation
|
@chr4 Are you OK with getting this landed first before we continue with the extension of The extension requires some consensus on new Netplan YAML schema, so it takes a bit longer, but the few lines from this PR should already fix the issue, while providing a (limited) KeepConfiguration= setting. Let me know what you think! PS: I attributed the changes to your name. |
|
No issues with taking the long road here, I agree that this is more consistent (and solves a few issues that came up in the discussion of #409).
Thanks, much apprechiated! |
slyon
added
the
community
|
|
||
| [DHCP] | ||
| CriticalConnection=true | ||
| KeepConfiguration=true |
There was a problem hiding this comment.
They put it into Network section, though it still modifies DHCPv4 behaviour.
DHCP.CriticalConnection / DHCPv4.CriticalConnection => Network.KeepConfiguration
https://www.freedesktop.org/software/systemd/man/latest/systemd.network.html#KeepConfiguration=
There was a problem hiding this comment.
Very good catch, thanks a lot! Fixed in 76e896a
3 participants
Description
With systemd-v243 (which is the default since focal), the "CriticalConnection" attribute was
revamped into "KeepConfiguration" [1], addressing several issues, especially in high-availability
environents [2][3].
This PR is preparatory work for #409
If I understand the code correctly, it still uses "CriticalConnection" when setting "critical: true" in the netplan configuration.
Closes: https://bugs.launchpad.net/netplan/+bug/1896799
Checklist
make checksuccessfully.make check-coverage).