auth: add support for LEAP and EAP-PWD (LP: #2038811)#415
Merged
daniloegea merged 1 commit intocanonical:mainfrom Oct 12, 2023
Merged
auth: add support for LEAP and EAP-PWD (LP: #2038811)#415daniloegea merged 1 commit intocanonical:mainfrom
daniloegea merged 1 commit intocanonical:mainfrom
Conversation
slyon
approved these changes
Oct 11, 2023
Contributor
slyon
left a comment
slyon
left a comment
There was a problem hiding this comment.
Thank you very much! I think this should fix the case for the "leap" and "pwd" values of NetworkManager's 801-1x.eap setting. But there might be more, similar cases and we should think about implementing some generic (future proof) fallback, using networkmanager.passthrough.
daniloegea
force-pushed
the
key_mgmt_ieee8021x
branch
from
9f59402 to
a9e021e
Compare
Contributor
Author
|
Something is still missing, the commands below are still failing: |
daniloegea
force-pushed
the
key_mgmt_ieee8021x
branch
2 times, most recently
from
66a65eb to
62a2d52
Compare
slyon
approved these changes
Oct 12, 2023
Contributor
slyon
left a comment
slyon
left a comment
There was a problem hiding this comment.
LGTM with the reduced scope. Let's fix the bug at hand first and work on the generic solution afterwards.
nitpick: May I just suggest to add simple testcases for the new "leap"/"pwd" EAP methods in test_keyfile.py?
diff --git a/tests/parser/test_keyfile.py b/tests/parser/test_keyfile.py
index dbb992ed..7a6bd2ca 100644
--- a/tests/parser/test_keyfile.py
+++ b/tests/parser/test_keyfile.py
@@ -526,6 +526,12 @@ dns-search='''.format(UUID, method))
def test_keyfile_type_wifi_eap_ttls(self):
self._template_keyfile_type_wifi_eap('ttls')
+ def test_keyfile_type_wifi_eap_leap(self):
+ self._template_keyfile_type_wifi_eap('leap')
+
+ def test_keyfile_type_wifi_eap_pwd(self):
+ self._template_keyfile_type_wifi_eap('pwd')
+
def test_keyfile_type_wifi_eap_leap(self):
self.generate_from_keyfile('''[connection]
type=wifiThis changes add support for the LEAP and PWD EAP authentication methods for NetworkManager, wpa_supplicant (networkd) and the keyfile parser. Using these method through the NM GUI is causing problems because libnetplan will generate a broken keyfile. See LP: #2038811 Note that the NM GUI supports more methods not recognized by netplan and we probably should also implement them later.
daniloegea
force-pushed
the
key_mgmt_ieee8021x
branch
from
62a2d52 to
e4bfabc
Compare
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changes add support for the LEAP and PWD EAP authentication methods for NetworkManager, wpa_supplicant (networkd) and the keyfile parser.
Using these method through the NM GUI is causing problems because libnetplan will generate a broken keyfile. See LP: #2038811
Note that the NM GUI supports more methods not recognized by netplan and we probably should also implement them later.
Reproducers
Description
Checklist
make checksuccessfully.make check-coverage).