wireguard: ignore empty endpoints (LP: #2038811)#414
Merged
daniloegea merged 1 commit intocanonical:mainfrom Oct 11, 2023
Merged
wireguard: ignore empty endpoints (LP: #2038811)#414daniloegea merged 1 commit intocanonical:mainfrom
daniloegea merged 1 commit intocanonical:mainfrom
Conversation
slyon
approved these changes
Oct 10, 2023
Contributor
slyon
left a comment
slyon
left a comment
There was a problem hiding this comment.
LGTM, except for a little inline comment, which should probably be fixed.
The Network Manager GUI will emit 'Endpoint=' if it's not specified when creating the tunnel. libnetplan is generating 'endpoint: ""' in this case and the parser is returning an error. In nm-parse, if Endpoint is either empty or NULL we'll just not read it. In the parser, if we find 'endpoint: ""', we'll just ignore it as if it were not defined. See LP: #2038811
daniloegea
force-pushed
the
wg_empty_endpoint
branch
from
2e331bc to
e51b93a
Compare
Contributor
|
Thanks for fixing! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Network Manager GUI will emit 'Endpoint=' if it's not specified when creating the tunnel. libnetplan is generating 'endpoint: ""' in this case and the parser is returning an error.
In nm-parse, if Endpoint is either empty or NULL we'll just not read it. In the parser, if we find 'endpoint: ""', we'll just ignore it as if it were not defined.
See LP: #2038811
Description
Checklist
make checksuccessfully.make check-coverage).