tunnels/validation: do not error out if "local" is not defined#407
Merged
daniloegea merged 2 commits intocanonical:mainfrom Sep 4, 2023
Merged
tunnels/validation: do not error out if "local" is not defined#407daniloegea merged 2 commits intocanonical:mainfrom
daniloegea merged 2 commits intocanonical:mainfrom
Conversation
The "local" IP property is not required by backends so we shouldn't error out if it's not defined.
daniloegea
force-pushed
the
tunnels_local
branch
from
dc22f01 to
b81bf9c
Compare
Copy a few tunnels common tests and remove the local address to ensure both backends will work fine.
slyon
approved these changes
Sep 4, 2023
Contributor
slyon
left a comment
slyon
left a comment
There was a problem hiding this comment.
This is relaxing the validation a bit, in accordance with the backend's rules. LGTM.
Could you please create a bug report about it on Launchpad, so we can get it landed in Ubuntu post feature freeze?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The "local" IP property is not required by backends so we shouldn't error out if it's not defined.
Tracking LP bug https://bugs.launchpad.net/ubuntu/+source/netplan.io/+bug/2034067
Description
Checklist
make checksuccessfully.make check-coverage).