Skip to content

wifi: support WPA2 and WPA3 Personal simultaneously#404

Merged
daniloegea merged 1 commit intocanonical:mainfrom
daniloegea:wpa2_wpa3_personal
Aug 28, 2023
Merged

wifi: support WPA2 and WPA3 Personal simultaneously#404
daniloegea merged 1 commit intocanonical:mainfrom
daniloegea:wpa2_wpa3_personal

Conversation

@daniloegea
Copy link
Contributor

@daniloegea daniloegea commented Aug 25, 2023

When using WPA-PSK and defining the password without the "auth" section, enable support for both WPA2 and 3 Personal. This will set the support for Protected Management Frames to optional implicitly.

Description

Checklist

  • Runs make check successfully.
  • Retains 100% code coverage (make check-coverage).
  • New/changed keys in YAML format are documented.
  • (Optional) Adds example YAML for new feature.
  • (Optional) Closes an open bug in Launchpad.

When using WPA-PSK and defining the password without the "auth" section,
enable support for both WPA2 and 3 Personal. This will set the support
for Protected Management Frames to optional implicitly.
@daniloegea daniloegea marked this pull request as ready for review August 28, 2023 15:04
@daniloegea daniloegea requested a review from slyon August 28, 2023 15:04
Copy link
Contributor

@slyon slyon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! LGTM.

This should keep simple things simple. Allowing the casual user to "just connect" to any WPA2/3 personal network, providing only their password, as discussed in #402

@daniloegea daniloegea merged commit 5f1192c into canonical:main Aug 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants