Post 0.107 cleanup & dropping API/ABI compat#400
Conversation
|
Few more things to remember:
|
see #401 |
slyon
force-pushed
the
post-0107
branch
8 times, most recently
from
3796fb9 to
e6e8d20
Compare
slyon
force-pushed
the
post-0107
branch
2 times, most recently
from
5c3fda5 to
706ccf9
Compare
slyon
changed the title
slyon
force-pushed
the
post-0107
branch
4 times, most recently
from
b11fec3 to
dd71696
Compare
daniloegea
left a comment
daniloegea
left a comment
There was a problem hiding this comment.
It's looking good so far. The only thing we must fix are the tests that are failing. They just need to be zeroed because the \0 is missing when the strings are compared (see my comment in the test).
slyon
force-pushed
the
post-0107
branch
8 times, most recently
from
7dd4f86 to
c152ea4
Compare
New ctests to satisfy coverage
|
Thanks for your review @daniloegea ! I've addressed all of your comments and got the CI to be green (except for the known tunnel/GRE failures on Jammy autopkgtest, which are unrelated). PTAL. |
| rm -r debian/patches/ # clear any distro patches | ||
| sed -i 's|rm debian/tmp/lib/netplan/generate|# DELETED|' debian/rules | ||
| # usrmerge-fix | ||
| mkdir debian/extra |
There was a problem hiding this comment.
I believe this will start to fail when your changes get synced with Ubuntu but we can fix the CI again later.
There was a problem hiding this comment.
Yes. And I just uploaded 0.107.1-2 into Debian unstable. I'll use my next PR to adopt CI accordingly, once that landed.
2 participants
Description
Note
Please review commit-by-commit (and ignore the huge "ABI: regenerate compat check for dropped symbols" commit in
abi-compat/*.xml-- it's autogenerated)Unrelated changes
This PR contains some unrelated "cleanup" changes for post 0.107 tasks.
Primary changes
The primary changes, of dropping legacy Netplan API and ABI (in preparation for a breaking 1.0 release) start from commit "test:generator:base: Refactor to use new API".
Checklist
make checksuccessfully.make check-coverage).