commands/status: show routes from all routing tables#390
Merged
daniloegea merged 2 commits intocanonical:mainfrom Aug 8, 2023
Merged
commands/status: show routes from all routing tables#390daniloegea merged 2 commits intocanonical:mainfrom
daniloegea merged 2 commits intocanonical:mainfrom
Conversation
daniloegea
force-pushed
the
netplan_status_route_tables
branch
from
91903a8 to
1f65355
Compare
slyon
approved these changes
Aug 8, 2023
Contributor
slyon
left a comment
slyon
left a comment
There was a problem hiding this comment.
Thank you, I like the hiding of the extra routing table information behind a --verbose flag!
I put two small remarks inline, but nothing critical. So feel free to merge as-is if you feel like.
LGTM.
added 2 commits
August 8, 2023 13:54
Use the := operator to make the for loop a bit simpler.
We were listing routes from only the main table. The new diff functionality will need all routes in order to calculate the diff properly. The extra routes are not displayed by default. A new parameter, --verbose, was added and the extra routes will be displayed when netplan status is called with it.
daniloegea
force-pushed
the
netplan_status_route_tables
branch
from
1f65355 to
90f0a3f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
While working on
netplan diffI realizednetplan statusdoesn't query all the routing tables. This information will be necessary fornetplan diff. But I wonder if we should show them all innetplan status... maybe it could be hidden behind a--verboseoption and show only the main table by default.Here is the change in the output:
Checklist
make checksuccessfully.make check-coverage).