CLI: Refactoring to avoid namespace clash with public bindings#387
Merged
slyon merged 2 commits intocanonical:mainfrom Aug 1, 2023
Merged
CLI: Refactoring to avoid namespace clash with public bindings#387slyon merged 2 commits intocanonical:mainfrom
slyon merged 2 commits intocanonical:mainfrom
Conversation
slyon
force-pushed
the
cli_namespace_refactor
branch
from
8e18e0a to
13fd7b3
Compare
slyon
changed the title
slyon
force-pushed
the
cli_namespace_refactor
branch
from
13fd7b3 to
0a8ec63
Compare
slyon
force-pushed
the
cli_namespace_refactor
branch
from
0a8ec63 to
42a1cdc
Compare
daniloegea
approved these changes
Aug 1, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Prerequisite to #385 due to the duplicated
netplanmodule namespace (public vs private module).Our private/internal module in
/usr/share/netplan/netplan/has a namespace clash with the new public bindings module (#385), supposed to be in/usr/lib/python3/dist-packages/netplan/. So let's rename the internal module and adopt our testing infrastructure to the new name, to make room for the public bindings.Checklist
make checksuccessfully.make check-coverage).