parse-nm: handle cloned-mac-address special cases (LP: #2026230)#376
Merged
slyon merged 1 commit intocanonical:mainfrom Jul 10, 2023
Merged
parse-nm: handle cloned-mac-address special cases (LP: #2026230)#376slyon merged 1 commit intocanonical:mainfrom
slyon merged 1 commit intocanonical:mainfrom
Conversation
The property "cloned-mac-address" might contain one of these special values: "preserve", "permanent", "random" and "stable". Currently we accept only a valid MAC address as value. This change will leave the cloned-mac-address property in the networkmanager.passthrough section if it contains one of these values and will try to validate it otherwise. Related to LP: #2026230
slyon
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The property "cloned-mac-address" might contain one of these special values: "preserve", "permanent", "random" and "stable". Currently we accept only a valid MAC address as value.
This change will leave the cloned-mac-address property in the networkmanager.passthrough section if it contains one of these values and will try to validate it otherwise.
Related to LP: #2026230
Description
This is a quick fix for the problem reported here https://bugs.launchpad.net/ubuntu/+source/network-manager/+bug/2026230
TODO: accept these values as part of Netplan's grammar and create an autopkgtest for network-manager.
Checklist
make checksuccessfully.make check-coverage).