Thanks so much for you contribution, @bengentil!

Your fix looks good. Do you think you can write a couple of unit test for it though?

You could add one for networkd and another for Network Manager in tests/generator/test_routing.py. Maybe calling them something like test_route_metric_rendering_lp2023681. It will ensure we'll not reintroduce this issue in the future.

Thanks again!

Hi @daniloegea, I've pushed a couple of tests.

The tests are testing against 4294967294, which is not strictly the max value as the max value is used internally to set the metric as undefined (NETPLAN_METRIC_UNSPEC == G_MAXUINT == 4294967295)

For more details see:

• netplan/src/netplan.c

  Line 570 in 012ce6a

  YAML_UINT_DEFAULT(def, event, emitter, "metric", r->metric, NETPLAN_METRIC_UNSPEC);

• netplan/src/netplan.c

  Line 64 in 012ce6a

  #define YAML_UINT_DEFAULT(_def, event_ptr, emitter_ptr, key, value, default_value) {\

This means technically 4294967295 can't be set as metric with netplan but this is another issue, here the goal is to avoid signed values as metrics.

Thank you for your bug fix! :)