Improve the coverage of the memory leak tests#365
Merged
schopin-pro merged 4 commits intocanonical:mainfrom Jun 8, 2023
Merged
Improve the coverage of the memory leak tests#365schopin-pro merged 4 commits intocanonical:mainfrom
schopin-pro merged 4 commits intocanonical:mainfrom
Conversation
added 4 commits
May 30, 2023 12:12
component->bond will be set twice if the parser processes the interface in a second pass.
component1->peer and component2->peer will be set twice if the parser processes the interface in a second pass.
It will be mainly used to help catching memory leaks.
The script was changed to run the test with both networkd and NetworkManager renderers (when possible). For the NetworkManager keyfiles generated in the second step, it will call the new tool to load it. It will improve the coverage of the memory leak tests.
daniloegea
force-pushed
the
check_keyfile_load_leaks
branch
from
e2ea01e to
2965626
Compare
schopin-pro
approved these changes
Jun 8, 2023
Contributor
schopin-pro
left a comment
schopin-pro
left a comment
There was a problem hiding this comment.
I like it :)
Good call on using the system netplan to change the renderer!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Now the run_asan.sh script will call the generator twice for each yaml file, once with renderer=networkd and again with renderer=NetworkManager.
When the renderer is set to NetworkManager, it will also call a new tool (keyfile_to_yaml.c) to load the keyfile.
Also, plug two memory leaks :)
Checklist
make checksuccessfully.make check-coverage).