CI: fix dch after adding the new 0.106.1 tag#364
Merged
schopin-pro merged 1 commit intocanonical:mainfrom May 26, 2023
Merged
Conversation
After adding the new tag from the stable/0.106 branch, dch is failing with: New version specified (0.106-78-g3074070) is less than the current version number (0.106.1-0ubuntu1)! Use -b to force. Basically, git describe is still describing the tag 0.106 and not 0.106.1. With this change, we'll first find the lastest tag before calling describe.
schopin-pro
approved these changes
May 26, 2023
Contributor
|
ACK. I haven't gone through all the scenarios in which this could fail down the line, and in the case of our CI config I figure a quickfix now is better than an hypothetical "correct" fix that doesn't yet exist. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After adding the new tag from the stable/0.106 branch, dch is failing with:
New version specified (0.106-78-g3074070) is less than
the current version number (0.106.1-0ubuntu1)! Use -b to force.
Basically, git describe is still describing the tag 0.106 and not 0.106.1.
With this change, we'll first find the lastest tag before calling describe.
Description
Checklist
make checksuccessfully.make check-coverage).