parse: set the backend on nm-devices to NM by default#349
Merged
slyon merged 2 commits intocanonical:mainfrom Apr 24, 2023
Merged
parse: set the backend on nm-devices to NM by default#349slyon merged 2 commits intocanonical:mainfrom
slyon merged 2 commits intocanonical:mainfrom
Conversation
By definition, the renderer on nm-devices must be NetworkManager. Not defining it will default to networkd. Apart from the fact it doesn't make sense, it is causing a memory leak because the function g_datalist_clear() will no be called in reset_backend_settings() if the backend is not NM.
Contributor
Author
|
The memory leak above is fixed by #348 |
slyon
approved these changes
Apr 24, 2023
Contributor
slyon
left a comment
slyon
left a comment
There was a problem hiding this comment.
+1
I was pondering if it makes sense to downgrade this to a g_debug(...) message, maybe only if renderer is NETPLAN_BACKEND_NONE.
But it's better to have this as an explicit warning. People are not supposed to be using nm-devices manually at all. It's fine for them to see a warning should they choose a wrong (or non at all) renderer.
daniloegea
added a commit
that referenced
this pull request
May 17, 2023
* parse: set the backend on nm-devices to NM by default By definition, the renderer on nm-devices must be NetworkManager. Not defining it will default to networkd. Apart from the fact it doesn't make sense, it is causing a memory leak because the function g_datalist_clear() will no be called in reset_backend_settings() if the backend is not NM. * parse.c: formatting
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By definition, the renderer on nm-devices must be NetworkManager. Not defining it will default to networkd. Apart from the fact it doesn't make sense, it is causing a memory leak because the function g_datalist_clear() will no be called in reset_backend_settings() if the backend is not NM.
Description
Checklist
make checksuccessfully.make check-coverage).