Merged
Conversation
The key doesn't need to be duplicated before being passed to g_datalist_set_data_full. It will not be freed.
5 tasks
slyon
approved these changes
Apr 24, 2023
Contributor
slyon
left a comment
slyon
left a comment
There was a problem hiding this comment.
lgtm! Just a small inline suggesting about using the GQuark API explicitly to make the code easier to understand.
daniloegea
added a commit
that referenced
this pull request
May 17, 2023
* parse: plug a memory leak The key doesn't need to be duplicated before being passed to g_datalist_set_data_full. It will not be freed. * parse: Use GQuark + GData API explicitly, avoiding the macro abstraction
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The key doesn't need to be duplicated before being passed to g_datalist_set_data_full. It will not be freed.
Description
Checklist
make checksuccessfully.make check-coverage).