nm: return if write_routes() fails#345
Merged
slyon merged 1 commit intocanonical:mainfrom Apr 24, 2023
Merged
Conversation
When routes validation fails we should return. It's also hitting an assertion later because the "error" object is already built: g_key_file_save_to_file: assertion 'error == NULL || *error == NULL' failed Add a test for coverage
daniloegea
force-pushed
the
fix_critical_assert_write_nm_conf
branch
from
6af5809 to
0edc613
Compare
slyon
approved these changes
Apr 24, 2023
Contributor
slyon
left a comment
slyon
left a comment
There was a problem hiding this comment.
ACK, lgtm.
That's the same we do further down when writing the [ipv4]/[ipv6] sections.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When routes validation fails we should return. It's also hitting an assertion later because the "error" object is already built:
Description
Checklist
make checksuccessfully.make check-coverage).