Skip to content

Some refactoring#338

Merged
slyon merged 4 commits intocanonical:mainfrom
slyon:refactorings
Apr 13, 2023
Merged

Some refactoring#338
slyon merged 4 commits intocanonical:mainfrom
slyon:refactorings

Conversation

@slyon
Copy link
Contributor

@slyon slyon commented Apr 3, 2023

Description

Cleanup a few basic things like:

  • using shutil.rmtree() over rm -rf subprocess call
  • clean up all the coverage data from the Makefile (make clean)
  • Use the more readable text=True alias to subprocess calls (over universal_newlines=True) – it's available since Python 3.7
  • Improve parameter passing to networkctl, accounting for network interfaces names that contain a leading -

Checklist

  • Runs make check successfully.
  • Retains 100% code coverage (make check-coverage).
  • New/changed keys in YAML format are documented.
  • (Optional) Adds example YAML for new feature.
  • (Optional) Closes an open bug in Launchpad.

@slyon slyon changed the title WIP: Refactorings Some refactoring Apr 13, 2023
@slyon slyon marked this pull request as ready for review April 13, 2023 08:35
@slyon slyon requested review from daniloegea and ogayot April 13, 2023 08:35
Copy link
Member

@ogayot ogayot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Copy link
Contributor

@daniloegea daniloegea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@slyon slyon merged commit 87aea1d into canonical:main Apr 13, 2023
@slyon slyon mentioned this pull request Apr 24, 2023
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants